Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Simplify canary release config #69

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

marikaner
Copy link
Contributor

This removes some of the config that I added previously:

  1. Keep only one package in the dummy changelog for canary - due to the fixed versioning this is enough.
  2. Do not ignore packages - all packages that should not be released have the private flag and this prevents them from being published.

This means for as long as we keep fixed versioning there is not need to adjust the config when changing the package structure.

@deekshas8 deekshas8 changed the title chore: simplify canary release config chore: Simplify canary release config Aug 13, 2024
@@ -7,5 +7,5 @@
"access": "public",
"baseBranch": "main",
"updateInternalDependencies": "patch",
"ignore": ["@sap-ai-sdk/sample-code", "@sap-ai-sdk/e2e-tests", "@sap-ai-sdk/type-tests"]
"ignore": []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[q] Can we remove this empty property altogether then?

Copy link
Contributor

@deekshas8 deekshas8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deekshas8 deekshas8 merged commit b920994 into main Aug 15, 2024
10 of 11 checks passed
@deekshas8 deekshas8 deleted the simplify-canary-config branch August 15, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants